forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: eliminate compilaton error due to the #define private public
macro in all unittests
#4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirk0830
changed the title
Fix: eliminate compilaton error due to the
Fix: eliminate compilaton error due to the Jul 18, 2024
#define private public
macro in esolver_dp#define private public
macro in unittest of esolver_dp
It seems there are still some issues with the compilation... |
Based on my local experiments, it is necessary to move all
statements before |
@Cstandardlib So I mean you have to deal with all these files, and move |
mohanchen
approved these changes
Jul 18, 2024
mohanchen
requested review from
Cstandardlib and
AsTonyshment
and removed request for
Cstandardlib and
AsTonyshment
July 18, 2024 23:05
kirk0830
changed the title
Fix: eliminate compilaton error due to the
Fix: eliminate compilaton error due to the Jul 19, 2024
#define private public
macro in unittest of esolver_dp#define private public
macro in all unittests
AsTonyshment
approved these changes
Jul 19, 2024
Compilation succeed! LGTM.😀 |
Build passing😆Thanks! |
mohanchen
approved these changes
Jul 19, 2024
mohanchen
added
the
Compile & CICD & Docs & Dependencies
Issues related to compiling ABACUS
label
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #4673
Unit Tests and/or Case Tests for my changes
What's changed?
#define private public
and#define protected public
with#undef private
and#undef protected
.#define private public
on gtest and gmock<sstream>
which is known to cause compilation crash with#define private public
-like macroAny changes of core modules? (ignore if not applicable)