Fix: dcu error in pw_force calculation #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
reviewed
Jul 26, 2024
source/module_hamilt_pw/hamilt_pwdft/kernels/rocm/stress_op.hip.cu
Outdated
Show resolved
Hide resolved
source/module_hamilt_pw/hamilt_pwdft/kernels/rocm/stress_op.hip.cu
Outdated
Show resolved
Hide resolved
dzzz2001
reviewed
Jul 27, 2024
source/module_hamilt_pw/hamilt_pwdft/kernels/rocm/stress_op.hip.cu
Outdated
Show resolved
Hide resolved
source/module_hamilt_pw/hamilt_pwdft/kernels/rocm/stress_op.hip.cu
Outdated
Show resolved
Hide resolved
dzzz2001
reviewed
Jul 27, 2024
source/module_hamilt_pw/hamilt_pwdft/kernels/rocm/stress_op.hip.cu
Outdated
Show resolved
Hide resolved
mohanchen
approved these changes
Jul 29, 2024
8 tasks
dyzheng
pushed a commit
to dyzheng/abacus-develop
that referenced
this pull request
Sep 6, 2024
* fix dcu. * avoid some repeat calculations. * fix an error of multipul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder
Add rocm kernel codes to fix dcu compile error in last PR#4555,