Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: let only one rank do file I/O in unittest of orb_io #5185

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

kirk0830
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5184

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@kirk0830 kirk0830 added the Bugs Bugs that only solvable with sufficient knowledge of DFT label Sep 27, 2024
@kirk0830 kirk0830 marked this pull request as draft September 27, 2024 06:59
@kirk0830 kirk0830 changed the title Fix: add MPI_Barrier after the read_abacus_orb to avoid Fix: let only one rank do file I/O in unittest of orb_io Sep 27, 2024
@kirk0830 kirk0830 marked this pull request as ready for review September 27, 2024 07:10
Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@WHUweiqingzhou WHUweiqingzhou merged commit 1c7a509 into deepmodeling:develop Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs that only solvable with sufficient knowledge of DFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: process asynchrony cause the failure of unittest of orbio
2 participants