Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor:Change the variable type. #5201

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Oct 3, 2024

Linked Issue

Fix #5195

What's changed?

  • Example: the varibale test_symmetry,test_charge,test_energy,test_pseudo_cell are set to bool type,but it compare with the numerical value.And the variable test_relax_method,test_relax_method are set to the numerical value in the test file.

@A-006 A-006 changed the title Refactor Refactor:Change the variable type. Oct 3, 2024
@mohanchen mohanchen added the Bugs Bugs that only solvable with sufficient knowledge of DFT label Oct 5, 2024
@mohanchen mohanchen merged commit 800987a into deepmodeling:develop Oct 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs that only solvable with sufficient knowledge of DFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched type and operations of test_symmetry and test_pseudo_cell
2 participants