Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix::Change the gamma_only_lcao when nspin=4 #5322

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix::Change the gamma_only_lcao when nspin=4 #5322

merged 3 commits into from
Oct 23, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Oct 22, 2024

Linked Issue

Fix #5321

Unit Tests and/or Case Tests for my changes

  • Add a unit test in read_input_item_test.cpp for the LCAO type when nspin=4 and gamma_only=1.

What's changed?

  • When nspin == 4 and gamma_only == 1 in the LCAO type, the current calculation is not supported. In the last PR, the notice indicating this limitation was deleted.

@A-006 A-006 marked this pull request as draft October 22, 2024 08:29
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Oct 22, 2024
@A-006 A-006 marked this pull request as ready for review October 23, 2024 04:15
@A-006 A-006 requested a review from Qianruipku October 23, 2024 04:15
@A-006 A-006 changed the title Refactor::Change the gamma_only_lcao when nspin=4 Fix::Change the gamma_only_lcao when nspin=4 Oct 23, 2024
@mohanchen mohanchen merged commit 55c5afb into deepmodeling:develop Oct 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

@Qianruipku Qianruipku Awaiting requested review from Qianruipku

Assignees
No one assigned
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A notice is missing
2 participants
@A-006 @mohanchen