Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix c++ interface bug #3613

Merged
merged 12 commits into from
Mar 28, 2024
Merged

fix c++ interface bug #3613

merged 12 commits into from
Mar 28, 2024

Conversation

CaRoLZhangxy
Copy link
Collaborator

@github-actions github-actions bot added the C++ label Mar 27, 2024
@CaRoLZhangxy CaRoLZhangxy requested a review from njzjz March 27, 2024 07:08
njzjz
njzjz reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the skip and TODO in #3578 and #3579? If the skipped tests can pass, this PR does work.

This was linked to issues Mar 27, 2024
[BUG] pt: C++ interface throws errors when the number of ranks is larger than the number of GPUs #3578
Closed
[BUG] pt: fix torch.cat error in the C++ interface when nloc==0 #3579
Closed
njzjz
njzjz requested changes Mar 27, 2024
View reviewed changes
source/api_cc/src/DeepPotPT.cc Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (f16d543) to head (a4ae015).

Files Patch % Lines
source/api_cc/src/DeepPotPT.cc 53.12% 12 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3613      +/-   ##
==========================================
- Coverage   77.72%   77.70%   -0.03%     
==========================================
  Files         434      434              
  Lines       37524    37550      +26     
  Branches     1620     1623       +3     
==========================================
+ Hits        29167    29179      +12     
- Misses       7496     7507      +11     
- Partials      861      864       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaRoLZhangxy CaRoLZhangxy requested a review from njzjz March 28, 2024 05:30
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 28, 2024
Merged via the queue into deepmodeling:devel with commit c2371cd Mar 28, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
C++ LAMMPS
Projects
None yet
Milestone
No milestone
3 participants
@CaRoLZhangxy @njzjz @wanghan-iapcm