Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove implicit Hs from RDKit SMILES #2102

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 6, 2024

Fix #2087.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d250806) 95.47% compared to head (0c3846f) 95.48%.

Files Patch % Lines
reacnetgenerator/_path.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   95.47%   95.48%           
=======================================
  Files          18       18           
  Lines        1460     1461    +1     
=======================================
+ Hits         1394     1395    +1     
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz enabled auto-merge January 6, 2024 06:56
@njzjz njzjz added this pull request to the merge queue Jan 6, 2024
Merged via the queue into deepmodeling:master with commit 89e66e8 Jan 6, 2024
33 checks passed
@njzjz njzjz deleted the format-smiles branch January 6, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant