Make functions accept str along with Message #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLKRo
reviewed
Mar 11, 2024
Co-authored-by: Roman Zlobin <[email protected]>
|
Could you also replace Messages with strings in happy paths that feature text-only messages? |
…ialog_flow_framework into chore/funcs_accept_str
# Conflicts: # dff/script/conditions/std_conditions.py
RLKRo
approved these changes
Jun 19, 2024
RLKRo
added a commit
that referenced
this pull request
Jul 3, 2024
# Changelog ## General - Framework renamed from DFF to Chatsky (#368) ## Features - New `has_text` condition for asserting that specific text is contained inside the last request (#335) - Validation stage reworked. `Pipeline.validation_stage`, `Pipeline.verbose` and `Context.validation` fields are removed. Added new type for annotating labels `dff.script.ConstLabel` (#289) - Functions `cnd.exact_match` and `check_happy_path` now accept both `Message` and `str`. The following are now equivalent: `exact_match(Message("text"))` == `exact_match("text")` (#337) - CLIMessengerInterface moved to `messengers.console` (#328) - Attachments reworked (#328): - `Session`, `Command`, `Link`, `Button`, `Keyboard` and `Attachments` classes removed, `Message.commands` field removed. - Added `CallbackQuery`, `Contact`, `Invoice`, `Poll`, `Animation`, `Sticker`, `VoiceMessage`, `VideoMessage` and `MediaGroup` classes. - Added attachment caching feature. - Added `has_callback_query` condition. - Removed `title` field from Data Attachments. Use `caption` instead. - Telegram Messenger interface reworked (#328): - Now provides methods for attachment byte download. - Added support for receiving attachment types as members of `Message.attachments`. Others may be accessed via `Message.original_message`. - Added support for sending new attachment types (`Sticker`, `Poll`, e.t.c.). - Added support for extra options such as `disable_notification`, `message_effect_id` or `caption`. - Telegram tutorials rewritten to reflect all the changes. - Added slots that simplify the process of extracting arbitrary data from user messages and accessing it later (#36): - New user guide and tutorials on slots ## Documentation - Return PRE_RESPONSE_PROCESSING and PRE_TRANSITION_PROCESSING tutorials - New telegram interface tutorials (#328) - Slots user guide and tutorials (#36) ## Contrib - Added `poe quick_test` to run tests that are not slow and do not require docker (#344) - `Context.framework_states` renamed to `Context.framework_data` and made `Pydantic.BaseModel` (#359) - Added `MessengerInterfaceWithAttachments` class (#328) - Added tools for enabling json serialization via pickle (#328) - Telegram tests made independent from telegram servers (#328) - `wrap_sync_function_in_async` moved to `utils.devel` (#36) # Checklist - [x] I have performed a self-review of the changes - [x] Rename repos (this; template; demo) - [ ] Add new logo; change favicons in conf.py (this can be done later) - [x] Create new PyPi project and update pypi token - [ ] Create a new release - [x] Make a new release on the [final_dff_release](https://github.com/deeppavlov/dialog_flow_framework/tree/final_dff_release) branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dff.script.conditions.exact_matchanddff.utils.testing.common.check_happy_pathacceptstralong withMessageexact_match(), but not forcheck_happy_path().exact_match(Message("some text"))toexact_match("some text")Checklist
To Consider