Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd/dff/template skill #303

Merged
merged 20 commits into from
Jun 19, 2023

Conversation

ruthenian8
Copy link
Member

Update dff_template_skill

skills/dff_template_skill/Dockerfile Outdated Show resolved Hide resolved
skills/dff_template_skill/server.py Outdated Show resolved Hide resolved
skills/dff_template_skill/server.py Outdated Show resolved Hide resolved
skills/dff_template_skill/tests/lets_talk_out.json Outdated Show resolved Hide resolved
…_v1; remove nulls from skill output; exclude nulls from test data; add run_dff function to serializer file
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/tests/lets_talk_out.json Outdated Show resolved Hide resolved
common/dff_api_v1/integration/serializer.py Outdated Show resolved Hide resolved
common/dff_api_v1/integration/serializer.py Outdated Show resolved Hide resolved
@ruthenian8 ruthenian8 requested a review from kudep February 3, 2023 09:45
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Show resolved Hide resolved
common/dff_api_v1/integration/serializer.py Outdated Show resolved Hide resolved
kudep
kudep previously approved these changes Feb 6, 2023
@dilyararimovna dilyararimovna marked this pull request as ready for review February 14, 2023 06:52
common/dff_api_v1/requirements.txt Outdated Show resolved Hide resolved
common/dff_api_v1/requirements.txt Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Show resolved Hide resolved
confidence: Optional[float] = None
human_attr: Optional[dict] = None
bot_attr: Optional[dict] = None
hype_attr: Optional[dict] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а сам текст реплики?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

конфиденс не optional

Copy link
Member Author

@ruthenian8 ruthenian8 Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а сам текст реплики?

Текст есть в классе, от которого наследуется DreamMessage

Kpetyxova
Kpetyxova previously approved these changes Mar 22, 2023
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Outdated Show resolved Hide resolved
skills/dff_template_skill/scenario/main.py Show resolved Hide resolved
dilyararimovna
dilyararimovna previously approved these changes May 22, 2023
@dilyararimovna
Copy link
Collaborator

@ruthenian8 не билдится контейнер, посмотри, пожалуйста

Building dff-template-skill

Step 1/15 : FROM python:3.9.16-slim

 ---> babdc67dc69c

Step 2/15 : WORKDIR /src

 ---> Using cache

 ---> 3443d7040b25

Step 3/15 : COPY common/dff_api_v1/requirements.txt .

 ---> 8fde444f502d

Step 4/15 : RUN pip install -r requirements.txt

 ---> Running in 6228efc7672d

Collecting git+https://github.com/deeppavlov/dialog_flow_framework@13921ae (from -r requirements.txt (line 9))

  Cloning https://github.com/deeppavlov/dialog_flow_framework (to revision 13921ae) to /tmp/pip-req-build-cl79m2fx

  ERROR: Error [Errno 2] No such file or directory: 'git' while executing command git version

ERROR: Cannot find command 'git' - do you have 'git' installed and in your PATH?

WARNING: You are using pip version 22.0.4; however, version 23.1.2 is available.

You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.

Service 'dff-template-skill' failed to build: The command '/bin/sh -c pip install -r requirements.txt' returned a non-zero code: 1

script returned exit code 1

@ruthenian8
Copy link
Member Author

@dilyararimovna Спасибо, поправил.

@ruthenian8 не билдится контейнер, посмотри, пожалуйста

Copy link
Contributor

@smilni smilni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

все хорошо, все поднимается и работает, по моим замечаниям все поправлено, по остальным вроде тоже)

@dilyararimovna dilyararimovna merged commit 04dbfbb into deeppavlov:dev Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants