Skip to content

Commit

Permalink
Fix ruff issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
rblst authored Sep 20, 2024
1 parent 4dcaafc commit 0e3eb32
Showing 1 changed file with 9 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def _create_table_if_not_exists(self):
create_sql = SQL(CREATE_TABLE_STATEMENT).format(
schema_name=Identifier(self.schema_name),
table_name=Identifier(self.table_name),
embedding_dimension=SQLLiteral(self.embedding_dimension)
embedding_dimension=SQLLiteral(self.embedding_dimension),
)

self._execute_sql(create_sql, error_msg="Could not create table in PgvectorDocumentStore")
Expand All @@ -281,12 +281,12 @@ def delete_table(self):
"""
delete_sql = SQL("DROP TABLE IF EXISTS {schema_name}.{table_name}").format(
schema_name=Identifier(self.schema_name),
table_name=Identifier(self.table_name)
table_name=Identifier(self.table_name),
)

self._execute_sql(
delete_sql,
error_msg=f"Could not delete table {self.schema_name}.{self.table_name} in PgvectorDocumentStore"
error_msg=f"Could not delete table {self.schema_name}.{self.table_name} in PgvectorDocumentStore",
)

def _create_keyword_index_if_not_exists(self):
Expand Down Expand Up @@ -364,7 +364,7 @@ def _create_hnsw_index(self):
schema_name=Identifier(self.schema_name),
index_name=Identifier(self.hnsw_index_name),
table_name=Identifier(self.table_name),
ops=SQL(pg_ops)
ops=SQL(pg_ops),
)

if actual_hnsw_index_creation_kwargs:
Expand All @@ -384,8 +384,7 @@ def count_documents(self) -> int:
"""

sql_count = SQL("SELECT COUNT(*) FROM {schema_name}.{table_name}").format(
schema_name=Identifier(self.schema_name),
table_name=Identifier(self.table_name)
schema_name=Identifier(self.schema_name), table_name=Identifier(self.table_name)
)

count = self._execute_sql(sql_count, error_msg="Could not count documents in PgvectorDocumentStore").fetchone()[
Expand Down Expand Up @@ -413,8 +412,7 @@ def filter_documents(self, filters: Optional[Dict[str, Any]] = None) -> List[Doc
raise ValueError(msg)

sql_filter = SQL("SELECT * FROM {schema_name}.{table_name}").format(
schema_name=Identifier(self.schema_name),
table_name=Identifier(self.table_name)
schema_name=Identifier(self.schema_name), table_name=Identifier(self.table_name)
)

params = ()
Expand Down Expand Up @@ -455,8 +453,7 @@ def write_documents(self, documents: List[Document], policy: DuplicatePolicy = D
db_documents = self._from_haystack_to_pg_documents(documents)

sql_insert = SQL(INSERT_STATEMENT).format(
schema_name=Identifier(self.schema_name),
table_name=Identifier(self.table_name)
schema_name=Identifier(self.schema_name), table_name=Identifier(self.table_name)
)

if policy == DuplicatePolicy.OVERWRITE:
Expand Down Expand Up @@ -567,9 +564,9 @@ def delete_documents(self, document_ids: List[str]) -> None:
document_ids_str = ", ".join(f"'{document_id}'" for document_id in document_ids)

delete_sql = SQL("DELETE FROM {schema_name}.{table_name} WHERE id IN ({document_ids_str})").format(
schema_name=Identifier(self.schema_name),
schema_name=Identifier(self.schema_name),
table_name=Identifier(self.table_name),
document_ids_str=SQL(document_ids_str)
document_ids_str=SQL(document_ids_str),
)

self._execute_sql(delete_sql, error_msg="Could not delete documents from PgvectorDocumentStore")
Expand Down

0 comments on commit 0e3eb32

Please sign in to comment.