Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for native filters in QdrantDocumentStore #1093

Closed
Amnah199 opened this issue Sep 18, 2024 · 1 comment
Closed

Remove support for native filters in QdrantDocumentStore #1093

Amnah199 opened this issue Sep 18, 2024 · 1 comment
Assignees
@Amnah199
Labels
breaking change integration:qdrant P1

Comments

@Amnah199
Copy link
Contributor

Amnah199 commented Sep 18, 2024 •
edited
Loading

Summary and motivation

Currently the filter_documents method in QdrantDocumentStore accepts filters in Qdrant syntax. As other integrations do not support legacy or native filters, this method should accept only haystack filters.
@julian-risch julian-risch added P2 P1 and removed P2 labels Sep 19, 2024
@Amnah199 Amnah199 mentioned this issue Sep 26, 2024
Closed
@Amnah199 Amnah199 changed the title Remove support for legacy filters in QdrantDocumentStore Remove support for native filters in QdrantDocumentStore Sep 27, 2024
@Amnah199
Copy link
Contributor Author

Closing this, as its decided to keep support for native filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amnah199 Amnah199

Labels
breaking change integration:qdrant P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove support for native filters from Qdrant integration deepset-ai/haystack-core-integrations
2 participants
@julian-risch @Amnah199