fix: remove support for native filters from Qdrant integration #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:qdrant
type:documentation
Amnah199
requested review from
julian-risch and
vblagoje
and removed request for
a team and
julian-risch
|
It seems to me that we are not removing support for our legacy filters, but for Qdrant native filters. |
Amnah199
changed the title
|
@silvanocerza we would like your opinion about this PR. Stefano believes we should keep the support for native filters in Qdrant as some users rely on it. But I do not know of any other integrations that support native filters, so this will be an exception. Wdyt? |
|
I think we can keep them, ti gives more flexibility to users of the Document Store to create custom retrievers and what not. |
|
Closing this PR as we have decided not to proceed with merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Update the Qdrant document store and retrievers to remove support for Qdrant native filters. Only haystack filters can be provided as is the case in other integrations.
How did you test it?
Ran the existing tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.