fix: skip unsupported meta fields in PineconeDB #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbatista
requested review from
shadeMe and
anakin87
and removed request for
a team and
shadeMe
davidsbatista
changed the title
anakin87
reviewed
Aug 20, 2024
integrations/pinecone/src/haystack_integrations/document_stores/pinecone/document_store.py
Outdated
Show resolved
Hide resolved
integrations/pinecone/src/haystack_integrations/document_stores/pinecone/document_store.py
Outdated
Show resolved
Hide resolved
integrations/pinecone/src/haystack_integrations/document_stores/pinecone/document_store.py
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type:documentation
anakin87
approved these changes
Aug 21, 2024
integrations/pinecone/src/haystack_integrations/document_stores/pinecone/document_store.py
Outdated
Show resolved
Hide resolved
| assert "_split_overlap" not in pinecone_doc.meta | ||
|
|
||
|
|
||
| def test_validate_metadata_valid(): |
…s/pinecone/document_store.py Co-authored-by: Stefano Fiorucci <[email protected]>
Amnah199
pushed a commit
that referenced
this pull request
Oct 2, 2024
* initial import * nit * linting * PR comments * Update integrations/pinecone/src/haystack_integrations/document_stores/pinecone/document_store.py Co-authored-by: Stefano Fiorucci <[email protected]> * nit --------- Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
_split_overlapinmetais incompatible with some Document Stores haystack#8181How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.