feat: add tests for VertexAIGeminiGenerator and enable streaming #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
Amnah199
changed the title
julian-risch
requested changes
Aug 23, 2024
...ations/google_vertex/src/haystack_integrations/components/generators/google_vertex/gemini.py
Outdated
Show resolved
Hide resolved
...ations/google_vertex/src/haystack_integrations/components/generators/google_vertex/gemini.py
Show resolved
Hide resolved
...ations/google_vertex/src/haystack_integrations/components/generators/google_vertex/gemini.py
Outdated
Show resolved
Hide resolved
...ations/google_vertex/src/haystack_integrations/components/generators/google_vertex/gemini.py
Outdated
Show resolved
Hide resolved
...ations/google_vertex/src/haystack_integrations/components/generators/google_vertex/gemini.py
Outdated
Show resolved
Hide resolved
julian-risch
approved these changes
Aug 27, 2024
Amnah199
added a commit
that referenced
this pull request
Oct 2, 2024
* Add test_gemini.py and enable streaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
VertexAIGeminiGeneratorProposed Changes:
Add
streaming_callbackparameter inVertexAIGeminiGeneratorto enable streaming.How did you test it?
VertextAIGeminiGeneratorNotes for the reviewer
Streaming can also be implemented without using
StreamingChunkbut I decided to use it for consistency with other implementations we have in Bedrock, OpenAI etc.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.