feat: enable streaming in GoogleAIGemini #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:google-ai
type:documentation
Amnah199
requested review from
silvanocerza and
anakin87
and removed request for
a team and
silvanocerza
anakin87
reviewed
Aug 27, 2024
integrations/google_ai/src/haystack_integrations/components/generators/google_ai/chat/gemini.py
Outdated
Show resolved
Hide resolved
integrations/google_ai/src/haystack_integrations/components/generators/google_ai/chat/gemini.py
Show resolved
Hide resolved
integrations/google_ai/src/haystack_integrations/components/generators/google_ai/gemini.py
Outdated
Show resolved
Hide resolved
integrations/google_ai/tests/generators/chat/test_chat_gemini.py
Outdated
Show resolved
Hide resolved
anakin87
approved these changes
Aug 27, 2024
Amnah199
changed the title
Amnah199
added a commit
that referenced
this pull request
Oct 2, 2024
* Add streaming to GoogleAIGeminiGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add
streaming_callbacktoinitandrunmethods ofGoogleAIGeminiGeneratorandGoogleAIGeminiChatGenerator.How did you test it?
Notes for the reviewer
Similar to the PR for VertexAI: 1014
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.