Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemini with Makersuite #156

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Gemini with Makersuite #156

merged 11 commits into from
Jan 3, 2024

Conversation

TuanaCelik
Copy link
Member

@TuanaCelik TuanaCelik commented Dec 29, 2023

This is the first go at implementing Gemini support with Makersuite. Works with:

gemini-pro for just text
gemini-pro-vision for text + image
GeminiChatGenerator for function calling

Needs:

  • name changes
  • docstrings
  • tests

Contains: example.ipynb witn text generation on it's own, with images, and function calling

@TuanaCelik
Copy link
Member Author

PS: Adding the function calling support with these packages was a bit fiddly and the documentation for Gemini suggests that this is still experimental and in beta. So up to you whether you want to keep it or not

- [Installation](#installation)
- [License](#license)

## Installation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we direct readers to the docs for more information? I've noticed there are often more comprehensive code samples over there (and I agree it would be a pain to maintain them everywhere, especially for haystack core integrations.

@silvanocerza silvanocerza marked this pull request as ready for review January 3, 2024 10:56
@silvanocerza silvanocerza requested a review from a team as a code owner January 3, 2024 10:56
@silvanocerza silvanocerza requested review from shadeMe and removed request for a team January 3, 2024 10:56
@silvanocerza
Copy link
Contributor

silvanocerza commented Jan 3, 2024

I added some tests and related workflow, refactored the serialization of the components and also renamed them by prefixing them with GoogleAI. We're also going to rename the one in google-vertex-haystack with the VertexAI prefix to keep them in line with these components.

Most noticeable change is the rename of the package from gemini-haystack to google-ai-haystack. Better to be generic in this case, we don't know if Google is going to release other models or something different.

I also renamed the integration folder name to use underscores or the release process wouldn't work.

@silvanocerza silvanocerza merged commit 02914e1 into main Jan 3, 2024
9 checks passed
@silvanocerza silvanocerza deleted the gemini branch January 3, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants