Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a workflow to check the presence of release notes #5449

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 26, 2023

Related Issues

Proposed Changes:

Add a workflow that checks for the presence of a .yaml file in the releasenotes/notes folder in each PR. The check is skipped if the PR has the ignore-for-release-notes label attached.

How did you test it?

Manually tested on a different repo

Notes for the reviewer

This check doesn't validate the actual content of the release notes, this might be a nice-to-have follow up.

Checklist

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jul 26, 2023
@masci masci requested a review from a team as a code owner July 26, 2023 16:11
@masci masci requested review from anakin87 and removed request for a team July 26, 2023 16:11
@anakin87 anakin87 self-assigned this Jul 27, 2023
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I only left a comment...

.github/workflows/release_notes.yml Show resolved Hide resolved
@masci masci changed the title add workflow to check presence of release notes chore: Add a workflow to check the presence of release notes Jul 27, 2023
@masci masci merged commit 5f01391 into main Jul 27, 2023
5 checks passed
@masci masci deleted the massi/reno-check branch July 27, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI
Projects
None yet
2 participants