Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SentenceTransformersDocumentEmbedder #5606

Merged
merged 29 commits into from
Aug 28, 2023
Merged

feat: SentenceTransformersDocumentEmbedder #5606

merged 29 commits into from
Aug 28, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Introduce the SentenceTransformersDocumentEmbedder, a component that embeds a list of Documents.
The embedding of each Document is stored in the embedding field of the Document.
See the Embedders proposal.

How did you test it?

Some unit tests.

Notes for the reviewer

Depends on #5572
It's only a first draft.

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Aug 21, 2023
@anakin87 anakin87 self-assigned this Aug 21, 2023
@anakin87 anakin87 marked this pull request as ready for review August 23, 2023 15:57
@anakin87 anakin87 requested review from a team as code owners August 23, 2023 15:57
@anakin87 anakin87 requested review from dfokina and silvanocerza and removed request for a team August 23, 2023 15:57
@dfokina
Copy link
Contributor

dfokina commented Aug 24, 2023

jFYI – commited tiny docstrings updates directly

Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Base automatically changed from st-embedding-backend to main August 28, 2023 10:32
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5998783082

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 48.248%

Files with Coverage Reduction New Missed Lines %
utils/context_matching.py 1 95.7%
Totals Coverage Status
Change from base Build 5998738637: 0.07%
Covered Lines: 11453
Relevant Lines: 23738

💛 - Coveralls

@ZanSara ZanSara merged commit 72fe4fc into main Aug 28, 2023
54 checks passed
@ZanSara ZanSara deleted the st-document-embedder branch August 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants