Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
BaseTestComponent
fromtest.preview.components
#5550Proposed Changes:
Remove
BaseTestComponent
as it's not necessary anymore to test serialization.Next release of Canals will remove its
BaseTestComponent
and changesComponent
protocol so thatto_dict
andfrom_dict
mandatory.To avoid having a huge PR with tons of changes when we update Canals I'm removing it right now.
How did you test it?
I ran
pytest -x test/preview
locally.Notes for the reviewer
N/A
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.