Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BaseTestComponent #5613

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Remove BaseTestComponent #5613

merged 2 commits into from
Aug 23, 2023

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Remove BaseTestComponent as it's not necessary anymore to test serialization.

Next release of Canals will remove its BaseTestComponent and changes Component protocol so that to_dict and from_dict mandatory.

To avoid having a huge PR with tons of changes when we update Canals I'm removing it right now.

How did you test it?

I ran pytest -x test/preview locally.

Notes for the reviewer

N/A

Checklist

@silvanocerza silvanocerza self-assigned this Aug 23, 2023
@silvanocerza silvanocerza requested review from a team as code owners August 23, 2023 10:19
@silvanocerza silvanocerza requested review from dfokina and ZanSara and removed request for a team August 23, 2023 10:19
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5950052257

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.127%
Totals Coverage Status
Change from base Build 5904637917: 0.0%
Covered Lines: 11397
Relevant Lines: 23681
💛 - Coveralls

@ZanSara ZanSara merged commit 66f615a into main Aug 23, 2023
54 checks passed
@ZanSara ZanSara deleted the remove-base-test-component branch August 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees

@silvanocerza silvanocerza

Labels
topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove BaseTestComponent from test.preview.components
3 participants
@silvanocerza @coveralls @ZanSara