Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove self.warm_up() #5644

Merged
merged 1 commit into from
Aug 28, 2023
Merged

chore: remove self.warm_up() #5644

merged 1 commit into from
Aug 28, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Aug 28, 2023

Related Issues

  • fixes n/a

Proposed Changes:

  • Update LocalWhisperTranscriber to not call warm_up() when transcribing to be coherent with all other Haystack 2.0 components.

How did you test it?

Local tests run

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested a review from a team as a code owner August 28, 2023 14:46
@ZanSara ZanSara requested review from masci and silvanocerza and removed request for a team and masci August 28, 2023 14:46
@ZanSara ZanSara added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Aug 28, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6001358886

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 48.298%

Totals Coverage Status
Change from base Build 6001109377: -0.002%
Covered Lines: 11477
Relevant Lines: 23763

💛 - Coveralls

@ZanSara ZanSara merged commit 55235b0 into main Aug 28, 2023
52 of 53 checks passed
@ZanSara ZanSara deleted the fix-whisper-local-warmup branch August 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants