Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable passing an object parameter to pipeline.run() #5646

Closed
wants to merge 3 commits into from

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Aug 28, 2023

Related Issues

Proposed Changes:

  • Use shallow copy instead of deep copy

How did you test it?

locally with my own agent application

Notes for the reviewer

The proposed solution is open for discussion. Another solution would be to first pop out the object parameters before deepcopy(), and then add the object parameters back after deep copy.

Please let me know if a unit test is needed here.

Checklist

@faaany faaany requested review from a team as code owners August 28, 2023 15:17
@faaany faaany requested review from dfokina and ZanSara and removed request for a team August 28, 2023 15:17
@github-actions github-actions bot added the type:documentation Improvements on the docs label Aug 28, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 28, 2023

Pull Request Test Coverage Report for Build 6005629482

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 48.29%

Totals Coverage Status
Change from base Build 6003275560: 0.004%
Covered Lines: 11481
Relevant Lines: 23775

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't pass an object parameter to pipeline.run()
2 participants