chore: Move WebRetriever's new init parameter to last parameter position #5673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The change aims to minimize the potential for breaking existing clients by moving the new
WebRetriever
init parameters to the last position. This ensures backward compatibility while introducing new customization options.What:
Modified the
init
method ofWebRetriever
to pushallowed_domains
andlink_content_fetcher
as the last parameters in the method signature.How can it be used:
No changes in usage; two new parameters (
allowed_domains
andlink_content_fetcher
) have been added as the last init parameters for optional customization.How did you test it:
No new unit tests were added. The existing tests should cover the basic functionality. In fact, they should by their own nature test this change. I also reran all
WebRetriever
examples in examples dir.Notes For Reviewer:
Please ensure that the new parameters are correctly positioned and that this change doesn't introduce any unintended side effects or break existing functionality.