Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade openai-whisper and re-introduce audio extra #6319

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Nov 16, 2023

Related Issues

The previous openai-whisper version pinned tiktoken causing a version conflict with Haystack's dependencies. The most recent openai-whisper version now unpins tiktoken, which resolves the conflict: https://github.com/openai/whisper/blob/v20231106/requirements.txt#L6

Proposed Changes:

  • Upgrade openai-whisper to the latest version
  • Re-introduce audio extra
  • Install audio extra in workflows

How did you test it?

Still pending

Notes for the reviewer

I am still testing this and will report back here.

Checklist

@julian-risch julian-risch requested review from a team as code owners November 16, 2023 08:53
@julian-risch julian-risch requested review from masci and removed request for a team November 16, 2023 08:53
@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2023

Pull Request Test Coverage Report for Build 6889398688

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 40.48%

Files with Coverage Reduction New Missed Lines %
utils/scipy_utils.py 1 91.67%
nodes/audio/whisper_transcriber.py 22 25.97%
Totals Coverage Status
Change from base Build 6889380242: -0.004%
Covered Lines: 10615
Relevant Lines: 26223

💛 - Coveralls

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@julian-risch julian-risch merged commit 34ecff1 into main Nov 16, 2023
80 checks passed
@julian-risch julian-risch deleted the simplify-whisper-installation branch November 16, 2023 14:04
vblagoje pushed a commit that referenced this pull request Nov 22, 2023
* upgrade openai-whisper and re-introduce audio extra

* add audio extra to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants