Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact!: Remove symbols under the haystack.document_stores namespace #6714

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Jan 9, 2024

Related Issues

No issue, preparation work for plugging integrations import paths under the haystack. namespace.

Proposed Changes:

Remove symbols under haystack.document_stores and haystack.component.retrievers, now symbols must be imported explicitly, e.g.

from haystack.document_stores.in_memory import InMemoryDocumentStore
from haystack.components.retrievers.in_memory import InMemoryBM25Retriever

instead of

from haystack.document_stores import InMemoryDocumentStore
from haystack.components.retrievers import InMemoryEmbeddingRetriever

How did you test it?

Unit tests

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner January 9, 2024 20:25
@masci masci requested review from vblagoje and removed request for a team January 9, 2024 20:25
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Jan 9, 2024
@masci masci removed the request for review from vblagoje January 9, 2024 20:25
@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7478258034

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 87.074%

Totals Coverage Status
Change from base Build 7464280343: 0.2%
Covered Lines: 4217
Relevant Lines: 4843

💛 - Coveralls

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jan 10, 2024
@masci masci requested a review from a team as a code owner January 10, 2024 16:33
@masci masci requested review from dfokina and removed request for a team January 10, 2024 16:33
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants