Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: unify dependency management + hatch scripts #7079

Merged
merged 8 commits into from
Feb 26, 2024
Merged

ci: unify dependency management + hatch scripts #7079

merged 8 commits into from
Feb 26, 2024

Conversation

wochinge
Copy link
Contributor

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Feb 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8050338149

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.878%
Totals Coverage Status
Change from base Build 8048103834: 0.0%
Covered Lines: 5212
Relevant Lines: 5799
💛 - Coveralls

wochinge
wochinge commented Feb 23, 2024
View reviewed changes
.github/workflows/e2e.yml
@@ -28,15 +29,10 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON_VERSION }}
python-version: "${{ env.PYTHON_VERSION }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added quotes as this otherwise leads to issues with >= 3.10

@wochinge wochinge marked this pull request as ready for review February 26, 2024 10:17
@wochinge wochinge requested a review from a team as a code owner February 26, 2024 10:17
@wochinge wochinge requested review from davidsbatista and removed request for a team February 26, 2024 10:17
@silvanocerza
Copy link
Contributor

Merged main in, that should solve the failing e2e tests.

@wochinge wochinge merged commit ba49905 into main Feb 26, 2024
24 checks passed
@wochinge wochinge deleted the ci/full-hatch-setup branch February 26, 2024 14:40
@silvanocerza silvanocerza mentioned this pull request Feb 26, 2024
Merged
@anakin87 anakin87 mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@davidsbatista davidsbatista Awaiting requested review from davidsbatista davidsbatista is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:build/distribution topic:CI topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @coveralls @silvanocerza