Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log trace correlation #7206

Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat: log trace correlation #7206

merged 2 commits into from
Feb 27, 2024

Conversation

wochinge
Copy link
Contributor

Related Issues

Proposed Changes:

  • auto-correlate logs and traces in production settings

How did you test it?

  • added unit tests

Notes for the reviewer

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Feb 26, 2024
@wochinge wochinge changed the title Feat/log trace correlation feat: log trace correlation Feb 26, 2024
@wochinge wochinge marked this pull request as ready for review February 26, 2024 17:31
@wochinge wochinge requested review from a team as code owners February 26, 2024 17:31
@wochinge wochinge requested review from dfokina, shadeMe and masci and removed request for a team February 26, 2024 17:31
masci
masci approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side 👍

Base automatically changed from feat/structured-logging to main February 27, 2024 08:15
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Feb 27, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8061602806

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.004%) to 89.971%
Files with Coverage Reduction New Missed Lines %
logging.py 1 97.56%
tracing/opentelemetry.py 1 97.14%
tracing/datadog.py 2 94.59%
tracing/tracer.py 3 95.4%
Totals Coverage Status
Change from base Build 8061591365: 0.004%
Covered Lines: 5257
Relevant Lines: 5843
💛 - Coveralls

@wochinge wochinge merged commit 6fce2db into main Feb 27, 2024
23 checks passed
@wochinge wochinge deleted the feat/log-trace-correlation branch February 27, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@shadeMe shadeMe Awaiting requested review from shadeMe shadeMe is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @coveralls @masci