Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docstrings for the builder package #7248

Merged
merged 5 commits into from
Feb 28, 2024
Merged

fix docstrings for the builder package #7248

merged 5 commits into from
Feb 28, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Feb 28, 2024

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 28, 2024
@masci masci requested a review from a team as a code owner February 28, 2024 15:42
@masci masci requested review from shadeMe and removed request for a team February 28, 2024 15:42
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 28, 2024
Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after incorporating the following changes and checking the formatting of the rendered markdown file locally.

haystack/components/builders/answer_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/answer_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/dynamic_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/dynamic_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/dynamic_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/prompt_builder.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8083722123

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.004%) to 90.087%

Files with Coverage Reduction New Missed Lines %
components/builders/answer_builder.py 1 98.25%
components/websearch/searchapi.py 2 96.36%
components/builders/dynamic_chat_prompt_builder.py 3 93.02%
components/websearch/serper_dev.py 17 69.84%
Totals Coverage Status
Change from base Build 8082106810: -0.004%
Covered Lines: 5262
Relevant Lines: 5841

💛 - Coveralls

@masci masci merged commit cf1e284 into main Feb 28, 2024
20 checks passed
@masci masci deleted the massi/7099 branch February 28, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docstrings - haystack.components.builders
3 participants