Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add pip to test dependencies #8475

Merged
merged 4 commits into from
Oct 22, 2024
Merged

ci: add pip to test dependencies #8475

merged 4 commits into from
Oct 22, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Oct 22, 2024 •
edited
Loading

Related Issues

  • After the introduction of uv, some typing tests are failing.
  • This happens because pip is no longer installed by default and it is needed by mypy for installing missing stub packages.

Proposed Changes:

Add pip to test dependencies

How did you test it?

CI. In 875c413, I modified a python file to trigger the lint workflow.

See lint/typing tests passing.

Checklist

@anakin87 anakin87 changed the title Fix typing ci: add pip to test dependencies Oct 22, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11456171118

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.349%
Totals Coverage Status
Change from base Build 11435566584: 0.0%
Covered Lines: 7499
Relevant Lines: 8300
💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review October 22, 2024 08:22
@anakin87 anakin87 requested review from a team as code owners October 22, 2024 08:22
@anakin87 anakin87 requested review from dfokina and julian-risch and removed request for a team October 22, 2024 08:22
@anakin87 anakin87 mentioned this pull request Oct 22, 2024
Merged
julian-risch
julian-risch approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@anakin87 anakin87 enabled auto-merge (squash) October 22, 2024 08:31
@anakin87 anakin87 merged commit f6935d1 into main Oct 22, 2024
30 checks passed
@anakin87 anakin87 deleted the fix-typing branch October 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:build/distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @julian-risch