feat!: tracing with concurrency #8489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LastRemote
requested review from
dfokina and
vblagoje
and removed request for
a team
github-actions
bot
added
topic:tests
topic:core
type:documentation
silvanocerza
requested review from
silvanocerza
and removed request for
vblagoje
|
Can you please add a test that reproduces the issue you reported? Also there are some other tests failing, we should fix those too. |
Yes sure. I edited one of the existing unit tests to check for this additional parameter but it is failing now. I am taking a closer look at it now.
I agree. This will surely cause code conflicts with the cycle PR. |
LastRemote
force-pushed
the
feat/tracing-with-concurrency
branch
from
30d6d5b
to
a8d9007
Compare
Pull Request Test Coverage Report for Build 11495743757Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Issue: I ran into some issues after deploying a pipeline as a service with tracing enabled. If there are concurrent calls to run the pipeline, the structure of spans kinda messed up due to the fact that the "haystack.component.run" spans are attached to the "haystack.pipeline.run" span. I experimented primarily with Langfuse, and this gave me a giant span with nested pipeline runs overlapping each other, which is definitely not ideal.
Purposed solution: I have come up with a solution by adding an optional
parent_spanparameter in the trace context. Furthermore, I tweaked the Langfuse tracer integration such that it creates a new span/generation on top of the parent span if it is provided, or create a root span if not.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.