chore: bundle signing #843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decleaver
requested review from
UncleGedd,
jeff-mccoy,
mjnagel and
TristanHoladay
as code owners
|
Lingering questions because I know nothing about cosign 😅
|
UncleGedd
reviewed
Aug 16, 2024
| @@ -38,6 +38,9 @@ const ( | |||
| // Bundle pull config keys | |||
| V_BNDL_PULL_OUTPUT = "bundle.pull.output" | |||
| V_BNDL_PULL_KEY = "bundle.pull.key" | |||
|
|
|||
| // Bundle deploy config keys | |||
| V_BNDL_DEPLOY_KEY = "bundle.deploy.key" | |||
There was a problem hiding this comment.
What do you think of bundle.deployKey? Just thinking of ways to reduce YAML layers
|
@UncleGedd so what is currently in the PR covers the actual signing of the bundle.yaml similar to what zarf is doing. The difference is that zarf keeps an aggregatechecksum of everything in the zarf.yaml metadata, which we currently don't. We will need to add this to make the signing worth while. That being said, zarf is looking into updating the way that they do signing based on: So not sure where this falls in terms of priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes functionality for signing bundles, and verifying, inspecting and deploying signed bundles
Related Issue
Fixes #831
Type of change
Checklist before merging