Include things like github.com/foo.js or janl/github.com.js #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google has changed - sometime in the last months - that you can no longer install a .crx file simply by dragging it onto Chrome: it tells you that you can only install extensions from the Chrome Web Store. You can bypass this restriction by dragging the file onto the list of extensions in chrome://extensions, so I've updated the test in the Rake task to reflect that.
Example: localhost:3131/github.com.js Previously, we would only look for `~/.js/github.com.js`. Now, the following would also appear (if present): * `~/.js/github.com/pull-request-edit-button.js` * `~/.js/janl/github.com.js` * `~/.js/janl/github.com/gpl-warning.js` This should make it easier to share and fork repos of dotjs files, as well as putting features into their own "bundles" (inspired slightly by vim's pathogen).
|
While I understand how you think, randomly mixing semantically named directory levels with non-semantic ones will have lots of bad interactions; say, including a bundle from some guy named "com", "info" or "museum", for instance. Those would both run on the domains where his dns-semantically named subdirectories match, and on Something like johan@0881164 is way safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: suppose
djsdreceives aGET /github.com.jsPreviously, we would only look for
~/.js/github.com.js. Now, the following would also appear (if present):~/.js/github.com/pull-request-edit-button.js~/.js/janl/github.com.js~/.js/janl/github.com/gpl-warning.jsThis should make it easier to share and fork repos of dotjs files, as well as
putting features into their own "bundles" (inspired slightly by vim's pathogen).
(I also updated the chrome installation instructions - Google broke that a some point. Thanks, Google! Thgoogle.)