-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile and new installation methods supporting multi-user environments #107
Conversation
Regarding the first item on my TODO list:
|
Regarding the 2nd item on my TODO list: Doing complex checks here might make it hard for distro packagers to keep track of our changes...
|
Regarding the 3rd item on my TODO list:
|
Regarding the 5th item on my TODO list:
|
…ling, and add proper layout for buttons in uninstall dialog
@georgekaz I think I fixed all errors in Ubuntu 18.04 (and 19.10, 20.04) Can you try again? |
@fin-ger Sorry for delayed reply. Just tested the "all users" installation on 18.04 and it's working fine now, nice one! I don't have any other versions of ubuntu to hand but I do have manjaro with GNOME Shell 3.36.0 if you need a test there. |
… in gnome >=3.34, no further action is needed when using this extension under Ubuntu 20.04
Sorry 😅 but I have this issue on Ubuntu 20.04 since 5fd58c9:
Edit: also 19.10 |
Ah, damn. You need the dev packages for glib. For ubuntu it's |
What do you mean with that? |
Do not read the GLIB_COMPILE_SCHEMAS = /usr/bin/glib-compile-schemas This avoids a dependency on pkg-config and glib-dev libs, but makes it more difficult for package maintainers to hook into schemas compilation. |
The file missing is |
Hmm ... I have no experience as package maintainer, but I would go with the alternative to avoid the overhead 😅 |
I agree, if this causes trouble packaging this extension for a distro, we can change it. |
Exactly |
Fantastic job @fin-ger, I think it's ready to merge |
I tried to give you a shiny green check mark too 😅 |
This PR is now awaiting feedback and reviews.
TODO
- this should make it easier for package maintainers to grab a specific version of this extension
@martin31821 @mastercaution Can you test the new installation and review for the security issues?
Changes include:
build
for compiling the glib-schema (translation missing for now)package
produces a semver-named, extensions.gnome.org compatible, zip file for distribution in thetarget
folderclean
cleans thetarget
folderinstall
installs the extension itself to$PREFIX
uninstall
uninstalls the extension from$PREFIX
install-tool
installs the polkit rule and thecpufreqctl
tool, where thecpufreqctl
tool is installed to$PREFIX/local/bin
when aTOOL_SUFFIX
is provided, and to$PREFIX/bin
when noTOOL_SUFFIX
is provideduninstall-tool
uninstalls the polkit rule andcpufreqctl
tool from$PREFIX/bin
or$PREFIX/local/bin
release
increments themajor
,minor
, orpatch
version, updates the version in several files, and creates a git version tag which is then pushedtool
foldercpufreqctl
andinstaller.sh
to separate folder to make it easier for package maintainers to spot the files which need executable rightsscripts
folder contains therelease.sh
script for themake release
targetinstaller.sh check
returns exit code 5, the extension tools need updatingsrc/config.js
contains all path related configuration for this extension, so that distro packagers can easily patch paths to the distro's needssrc/update.js
contains a new menu to ask the user to update the extension tools