Rename function to prevent conflict to debase #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzmfreedom
force-pushed
the
modify_context_variable_name
branch
from
e34239a
to
f0e9366
Compare
|
Makes sense to me @tzmfreedom! I guess you could potentially bundle both debuggers (for example, |
tzmfreedom
added a commit
to tzmfreedom/byebug
that referenced
this pull request
Mar 21, 2018
ext/byebug/byebug.h
Outdated
| @@ -125,7 +125,7 @@ extern VALUE next_thread; | |||
|
|
|||
| /* functions from context.c */ | |||
| extern void Init_context(VALUE mByebug); | |||
There was a problem hiding this comment.
You need to replace this function as well, right?
There was a problem hiding this comment.
Thank you for your review. I fixed it.
tzmfreedom
force-pushed
the
modify_context_variable_name
branch
from
2421388
to
8cbe292
Compare
|
Thank you @tzmfreedom! |
This was referenced Mar 21, 2018
This was referenced Mar 22, 2018
tzmfreedom
added a commit
to tzmfreedom/byebug
that referenced
this pull request
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use byebug and debase gem simultaneously, there are conflict because extern function name is conflict each other.
For example, with byebug and debase gem, if we use
byebugmethod to debug code, the following error is occured (this is the same issue as #200 #360 )This is because both gem have extern function
Init_contextandcontext_createand if we call these function in byebug gem, it calls debase's function. (Maybe other development gem use these function name, becausecontextis commonly used variable name)This PR solve by renaming function.