Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: make it work with pry-remote #64

Conversation

emanresusername
Copy link

still very much a work in progress, but was a solid progression IMHO, hoping someone with a better understanding of all the things at play in this gem can move this along further/faster/better/etc.
trying to address #33 (pinning at 1.3.3 would break if i used the break command . . . which severely limited it's usefulness) and this issue
what this does atm:

  1. the pry repl shows up on the client like it should and works more or less like you'd expect until you use the finish or continue commands
  2. not totally sure exactly what finish is doing now, but seems to be stopping a lot more places than it should
  3. continue works to the extent that it'll get you to the next breakpoint you've set or go on with the execution of the program. . . but then it hangs inside pry remote
/usr/local/opt/rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/pry-remote-0.1.8/lib/pry-remote.rb:307:in `sleep': Interrupt
    from /usr/local/opt/rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/pry-remote-0.1.8/lib/pry-remote.rb:307:in `run'
    from /usr/local/opt/rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/pry-remote-0.1.8/bin/pry-remote:4:in `<top (required)>'
    from /usr/local/opt/rbenv/versions/2.2.2/bin/pry-remote:23:in `load'
    from /usr/local/opt/rbenv/versions/2.2.2/bin/pry-remote:23:in `<main>'

both these gems are great! it'd be awesome to get them playing nicely together!

@localredhead
Copy link

👍

@deivid-rodriguez
Copy link
Owner

@emanresusername Sorry for the delay and thanks for getting this work started. If someone wants to build on this, we need specs!

@vfonic
Copy link

vfonic commented Jul 27, 2015

+1!

@jaredbeck
Copy link
Contributor

If you just need pry-remote to work, you can remove pry-byebug (and byebug) from your Gemfile and add pry-nav, which gives you next, step, etc. Maybe not the right solution for everyone, but I hope it helps someone!

@emanresusername
Copy link
Author

so there hasn't been a commit to pry-remote in years
and there doesn't seem to be too much motivation here either
i'm also not in working in ruby much these days and this issue's been open for years itself
i think it's it's time to finally lay this one to rest
pry pry-byeeeeee-bug bug

@emanresusername emanresusername deleted the pry-remote-wip branch February 9, 2017 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants