-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pry-like stop on binding.pry #75
base: master
Are you sure you want to change the base?
Enable pry-like stop on binding.pry #75
Conversation
The CI Fail is because of RuboCop - but it's not giving me any information - just "Hook raised unexpected error." |
Great analysis but unforunately, 😢 this doesn't work on my machine. It's critical to do the gem install before the test because uninstalling pry-byebug actually fixes the original reported issue. Running I tried adding this to my
|
4e24253
to
14e104e
Compare
Poop. Looks like .pryrc isn't loaded until the actual Pry repl is started. We start Byebug before we start pry, so we've either got to do the |
Ok. Yeah, that works now @stephenprater. Awesome. 👍 This is definitely required (as you know) to make pry invoke.
I wonder if this would be the default if it's considered stable? @deivid-rodriguez |
Guys, I'll be off until mid october or so. I'll review and consider this when I'm back. Salud! |
@deivid-rodriguez would you be able to take a look at this now? I'm running into ConradIrwin/pry-rescue#71 and this would solve the problem for me. Thanks. |
@russelldavis No, sorry... I'll let you know when I get to it, but don't know when that'll be. In the mid time, you can use this branch if it works for you! |
Given the discussion in Issue #45, this adds a configuration option to enable pry-like behavior on
binding.pry.
I don't think this is either better or worse, exactly, but the "step 3" behavior does seem to break some popular pry plugins (like pry-rescue.)
I did some non-exhaustive poking around and it appears to fix that issue as well. It definitely fixes the described issue in #45 where the last line of the file can now be
binding.pry
I've left the default behavior as
:byebug
- so people who want the:pry
behavior can set it in their.pryrc
files.