Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2.7 support #115

Closed
10 of 11 tasks
goodmami opened this issue Jul 11, 2017 · 0 comments
Closed
10 of 11 tasks

Remove Python 2.7 support #115

goodmami opened this issue Jul 11, 2017 · 0 comments
Milestone

Comments

@goodmami
Copy link
Member

goodmami commented Jul 11, 2017

Python 2.7 is nearing it's end-of-life, so removing PyDelphin support for it by that time would be appropriate. There are some pieces of code that currently depend on PyDelphin's Python 2.7 support (e.g., by having Python 2.7-only scripts that import PyDelphin), though, so this issue is for tracking those dependencies.

  • JaEn's utils/select-rule.py

Any others?

This issue is also a good place to track the places in the PyDelphin code where we've had to bend to keep Python 2.7 compatibility (see the following places for comments in the code):

  • Numerous from __future__ import ... statements
  • delphin.util.stringtypes
  • delphin.repp._REPPGroupCall._apply()
  • delphin.commands._prepare_output_directory()
  • delphin.main.redent()
  • delphin.itsdb.unicode
  • delphin.itsdb._open_table()
  • delphin.exceptions.TdlParsingError
  • delphin.interfaces.rest.urljoin
  • delphin.mrs.util.etree_tostring

Other things to look for are calls to .encode() or .decode(), opportunities to use yield from instead of a loop over yield, NameErrors, etc.

@goodmami goodmami added this to the v1.0.0 milestone Oct 21, 2018
goodmami added a commit that referenced this issue Apr 18, 2019
Also remove the remaining Pegre dependency for delphin.util.SExpr.

Addresses #115
goodmami added a commit that referenced this issue Apr 18, 2019
goodmami added a commit that referenced this issue May 10, 2019
I think we can consider this to resolve #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant