Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider harmonizing processor interfaces #141

Closed
goodmami opened this issue Jun 1, 2018 · 0 comments
Closed

Consider harmonizing processor interfaces #141

goodmami opened this issue Jun 1, 2018 · 0 comments
Milestone

Comments

@goodmami
Copy link
Member

goodmami commented Jun 1, 2018

The ACE and REST interfaces do not have the same methods, so they cannot be easily swapped as processors in some pipeline (see #127). A standardized interface like this might be useful:

class BaseInterface(object):
    def process_item(self, datum):
        ...

It would also be nice if they harmonized on run information, although it makes somewhat less sense in the REST interface.

There's also a question of how to deal with parsing vs transfer vs generation. For ACE, the subclass model works well, but that doesn't work for the REST client.

Any breaking changes should wait retain backward compatibility until v1.0.0, and those changes should be listed in #139.

@goodmami goodmami added this to the v0.7.1 milestone Jun 7, 2018
goodmami added a commit that referenced this issue Jul 12, 2019
This moves the old delphin.web module to delphin.web.client and makes
the delphin.web.server module, intended to replace Bottlenose.

Also relevant is #141, as this changes the previous Client.parse() to
the more "harmonious" parser.interact().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant