Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL comments cannot currently appear on code lines #170

Closed
goodmami opened this issue Aug 28, 2018 · 0 comments
Closed

TDL comments cannot currently appear on code lines #170

goodmami opened this issue Aug 28, 2018 · 0 comments
Milestone
v0.9.0

Comments

@goodmami
Copy link
Member

The current match for comments looks for beginning-of-lines and/or end-of-lines, so I think it cannot work on the same line as code:

a := b. ; comment here?
a := #| comment here? |# b.

Write some tests and fix if necessary.
@goodmami goodmami added this to the v0.9.0 milestone Aug 28, 2018
goodmami added a commit that referenced this issue Sep 21, 2018
@goodmami
Add new-style TDL parsing.
a6e26b0 
This adds a lot of code to tdl.py, although much of the old stuff will
be removed in a future release. The new-style parsing is ~36% slower
at reading the ERG's lexicon, but it is better able to deal with
malformed TDL, and it handles docstrings and comments in all valid
places.

Addresses #153, #167, #168, and #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
1 participant
@goodmami