-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor issues with REPP #308
Comments
thanks for the clarification request, mike! i have tried to answer your questions in what i consider the official specification: http://moin.delph-in.net/ReppTop?action=diff&rev2=44&rev1=43 do those changes seem sufficient to clarify your points? |
Yes, my questions are answered and I like the answers. Thanks!
…On Aug 12, 2020, 6:17 PM +0800, Stephan Oepen ***@***.***>, wrote:
thanks for the clarification request, mike! i have tried to answer your questions in what i consider the official specification:
http://moin.delph-in.net/ReppTop?action=diff&rev2=44&rev1=43
do those changes seem sufficient to clarify your points?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@oepen I'm working to make my code consistent with the updated spec, and it occurs to me there's another set of issues regarding iterative groups (which I'll call "internal" groups to be consistent with the wiki text). Extending my numbering from above...
I think the cleanest way to resolve these issues is to disallow nested internal group definitions while allowing nested calls. The problem is a potential break in backward compatibility. Finally, I want to resolve some ambiguity around my use of "must" in (1) above. I think it is fine to define an internal group that is never called (like an inactive external group), but any internal group call must resolve to a group defined within the same module. Your text on the wiki is less ambiguous here. |
hi @goodmami, and thanks for pushing further! i think i have answered all of your follow-up question by adding at the end of the section on internal group to the REPP wiki page. in sum, i fail to see why you lean towards outlawing nested internal groups? that, to me (just now, at least), would seem like an unnecessary constraint. |
Thanks! I see that (6) and (7) have answers, but not (5), although the question in (5) is somewhat more philosophical than practical.
I'm not trying to outlaw nested internal groups. I'm just noticing that our specification would be more consistent if we outlawed nested internal group definitions. The definitions are non-sequential while the internal group calls are sequential, so disallowing nested definitions would be consistent with this passage:
Disallowing them also removes the question about whether there's a separate namespace inside internal groups (meaning the clarification text you added about the global namespace would become unnecessary). Regarding the wiki text here:
I'm not seeing why the nested internal group definition is useful. As things currently stand, it seems like these are equivalent:
and
I thought nested definitions weren't actually used in practice, but I see that there is one in the ERG's
So the backward-compatibility-break would be more consequential than I originally thought. |
Coming back to this, here are things to do based on the wiki updates by Stephan:
edit: PyDelphin allows for a default tokenizer and I may have been reading the spec too strictly, so I changed the requirement about tokenization patterns in non-top-level modules. |
Part of #308 The line of code changed in repp.py is only defensive and not directly related to the tests. It is to avoid a NameError in the event that a group ever returns nothing, but currently that is not the case.
There are some parts of the REPP spec (spread across ReppTop wiki and various publications) that are not completely clear. PyDelphin currently makes guesses about the proper behavior, but it would be good to confirm them with others.
The text was updated successfully, but these errors were encountered: