You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pred, ElementaryPredication, and Node components all have an is_quantifier() method, but only in ElementaryPredication does it look for the RSTR role on its arguments (because only EPs have arguments as part of the data structure).
Where the information is available (e.g. in converting from MRS to DMRS), the RSTR role should only be used in determining if something is a quantifier.
We should possibly also deprecate is_quantifier() on Node and Pred, and instead use something like xmrs.nodeids(quantifier=True) in order to get this information. If someone wants to use the generally-but-not-necessarily-true assumption that a Node or Pred with q as the pos value is a quantifier, they can look directly at pred.pos.
The text was updated successfully, but these errors were encountered:
Pred, ElementaryPredication, and Node components all have an
is_quantifier()
method, but only in ElementaryPredication does it look for the RSTR role on its arguments (because only EPs have arguments as part of the data structure).Where the information is available (e.g. in converting from MRS to DMRS), the RSTR role should only be used in determining if something is a quantifier.
We should possibly also deprecate
is_quantifier()
on Node and Pred, and instead use something likexmrs.nodeids(quantifier=True)
in order to get this information. If someone wants to use the generally-but-not-necessarily-true assumption that a Node or Pred withq
as the pos value is a quantifier, they can look directly atpred.pos
.The text was updated successfully, but these errors were encountered: