Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantifier checks not always looking for RSTR role. #84

Closed
goodmami opened this issue Nov 3, 2016 · 1 comment
Closed

Quantifier checks not always looking for RSTR role. #84

goodmami opened this issue Nov 3, 2016 · 1 comment
Milestone

Comments

@goodmami
Copy link
Member

goodmami commented Nov 3, 2016

Pred, ElementaryPredication, and Node components all have an is_quantifier() method, but only in ElementaryPredication does it look for the RSTR role on its arguments (because only EPs have arguments as part of the data structure).

Where the information is available (e.g. in converting from MRS to DMRS), the RSTR role should only be used in determining if something is a quantifier.

We should possibly also deprecate is_quantifier() on Node and Pred, and instead use something like xmrs.nodeids(quantifier=True) in order to get this information. If someone wants to use the generally-but-not-necessarily-true assumption that a Node or Pred with q as the pos value is a quantifier, they can look directly at pred.pos.

@goodmami
Copy link
Member Author

Fixed in 2888d1d. Pred.is_quantifier() and Node.is_quantifier() are deprecated in 39ee95e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant