Update PresignedUrlCache exception message for clarity #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Today, when a job doesn't access the delta table before `expireAfterAccessMs`, the presigned url is removed from the cache. When the job does try to access that table, the entry is removed from the concurrent hash map and an IllegalStateException is thrown. This exception message says the table was "removed". The message is confusing if the developer doesn't understand the table was "removed" from the cache. It is not unreasonable for the developer to be confused that the delta table was suddenly removed completely! How this works: This changes the exception message to carry the expireMilliseconds information in the stack trace. This should help developers understand and adjust their job configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Today, when a job doesn't access the delta table before
expireAfterAccessMs, the presigned url is removed from the cache. When the job does try to access that table, the entry is removed from the concurrent hash map and an IllegalStateException is thrown. This exception message says the table was "removed". The message is confusing if the developer doesn't understand the table was "removed" from the cache. It is not unreasonable for the developer to be confused that the delta table was suddenly removed completely!How this works:
This changes the exception message to carry the expireMilliseconds information in the stack trace. This should help developers understand and adjust their job configurations