Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark] Mark DeltaConfig.DATA_SKIPPING_NUM_INDEXED_COLS lazy #3707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Spark] Mark DeltaConfig.DATA_SKIPPING_NUM_INDEXED_COLS lazy #3707

wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Contributor

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR proposes to mark DeltaConfig.DATA_SKIPPING_NUM_INDEXED_COLS lazy. Otherwise, it might ending up with null because of the initialization order. See the stacktrace below:

An exception or error caused a run to abort.  (6 seconds, 718 milliseconds)
  java.lang.ExceptionInInitializerError:
  at com.databricks.sql.transaction.tahoe.DeltaConfigsBase.$init$(DeltaConfig.scala:557)
  at com.databricks.sql.transaction.tahoe.DeltaConfigs$.<init>(DeltaConfig.scala:829)
  at com.databricks.sql.transaction.tahoe.DeltaConfigs$.<clinit>(DeltaConfig.scala)
  at com.databricks.sql.SqlGatewayConfig$.sqlGatewayDefaultConfigs(SqlGatewayConfig.scala:135)
  at com.databricks.sql.SqlGatewayConfig$.setDefaultConfigurations(SqlGatewayConfig.scala:493)
  at com.databricks.sql.DatabricksEdge.customizeConf(DatabricksEdge.scala:504)
  at com.databricks.sql.DatabricksEdge.customizeConf$(DatabricksEdge.scala:501)
  at org.apache.spark.sql.internal.SessionStateBuilder.customizeConf(SessionState.scala:202)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.$anonfun$conf$2(BaseSessionStateBuilder.scala:109)
  at scala.Option.getOrElse(Option.scala:189)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.conf$lzycompute(BaseSessionStateBuilder.scala:103)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.conf(BaseSessionStateBuilder.scala:96)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.build(BaseSessionStateBuilder.scala:476)
  at org.apache.spark.sql.SparkSession$.org$apache$spark$sql$SparkSession$$instantiateSessionState(SparkSession.scala:1806)
  at org.apache.spark.sql.SparkSession.$anonfun$sessionState$2(SparkSession.scala:332)
  at scala.Option.getOrElse(Option.scala:189)
  at org.apache.spark.sql.SparkSession.sessionState$lzycompute(SparkSession.scala:330)
  at org.apache.spark.sql.SparkSession.sessionState(SparkSession.scala:325)
  at org.apache.spark.sql.SparkSession.conf$lzycompute(SparkSession.scala:396)
  at org.apache.spark.sql.SparkSession.conf(SparkSession.scala:394)
  at org.apache.spark.sql.SQLContext.setConf(SQLContext.scala:144)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.startThriftServer(SharedThriftServer.scala:159)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.$anonfun$beforeAll$1(SharedThriftServer.scala:91)
  at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
  at scala.util.Try$.apply(Try.scala:213)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.beforeAll(SharedThriftServer.scala:91)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.beforeAll$(SharedThriftServer.scala:88)
  at com.databricks.sql.hive.thriftserver.MultiClusterQueryResultCacheBaseSuite.org$apache$spark$sql$execution$qrc$MockCloudStorageTestUtils$$super$beforeAll(MultiClusterQueryResultCacheSuites.scala:51)
  at org.apache.spark.sql.execution.qrc.MockCloudStorageTestUtils.beforeAll(MockCloudStorageTestUtils.scala:23)
  at org.apache.spark.sql.execution.qrc.MockCloudStorageTestUtils.beforeAll$(MockCloudStorageTestUtils.scala:21)
  at com.databricks.sql.hive.thriftserver.MultiClusterQueryResultCacheBaseSuite.beforeAll(MultiClusterQueryResultCacheSuites.scala:86)
  at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:212)
  at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
  at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
  at org.apache.spark.SparkFunSuite.run(SparkFunSuite.scala:611)
  at org.scalatest.tools.SuiteRunner.run(SuiteRunner.scala:47)
  at org.scalatest.tools.Runner$.$anonfun$doRunRunRunDaDoRunRun$13(Runner.scala:1321)
  at org.scalatest.tools.Runner$.$anonfun$doRunRunRunDaDoRunRun$13$adapted(Runner.scala:1315)
  at scala.collection.immutable.List.foreach(List.scala:431)
  at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:1315)
  at org.scalatest.tools.Runner$.$anonfun$runOptionallyWithPassFailReporter$24(Runner.scala:992)
  at org.scalatest.tools.Runner$.$anonfun$runOptionallyWithPassFailReporter$24$adapted(Runner.scala:970)
  at org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:1481)
  at org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:970)
  at org.scalatest.tools.Runner$.run(Runner.scala:798)
  at com.databricks.scalatest.ScalaTestRunnerWrapper$.main(ScalaTestRunnerWrapper.scala:53)
  at com.databricks.scalatest.ScalaTestRunnerWrapper.main(ScalaTestRunnerWrapper.scala)
  Cause: java.lang.NullPointerException: Cannot invoke "com.databricks.sql.transaction.tahoe.DeltaConfig.defaultTablePropertyKey()" because the return value of "com.databricks.sql.transaction.tahoe.DeltaConfigs$.CHECKPOINT_WRITE_STATS_AS_STRUCT()" is null
  at com.databricks.sql.SqlGatewayConfig$.sqlGatewayDefaultConfigs(SqlGatewayConfig.scala:135)
  at com.databricks.sql.SqlGatewayConfig$.setDefaultConfigurations(SqlGatewayConfig.scala:493)
  at com.databricks.sql.DatabricksEdge.customizeConf(DatabricksEdge.scala:504)
  at com.databricks.sql.DatabricksEdge.customizeConf$(DatabricksEdge.scala:501)
  at org.apache.spark.sql.internal.SessionStateBuilder.customizeConf(SessionState.scala:202)
  at org.apache.spark.sql.internal.WithTestConf.$anonfun$conf$4(BaseSessionStateBuilder.scala:527)
  at scala.Option.getOrElse(Option.scala:189)
  at org.apache.spark.sql.internal.WithTestConf.conf(BaseSessionStateBuilder.scala:517)
  at org.apache.spark.sql.internal.WithTestConf.conf$(BaseSessionStateBuilder.scala:509)
  at org.apache.spark.sql.test.TestSQLSessionStateBuilder.conf$lzycompute(TestSQLContext.scala:86)
  at org.apache.spark.sql.test.TestSQLSessionStateBuilder.conf(TestSQLContext.scala:86)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.build(BaseSessionStateBuilder.scala:476)
  at org.apache.spark.sql.test.TestSparkSession.sessionState$lzycompute(TestSQLContext.scala:48)
  at org.apache.spark.sql.test.TestSparkSession.sessionState(TestSQLContext.scala:47)
  at org.apache.spark.sql.SparkSession.$anonfun$new$3(SparkSession.scala:180)
  at scala.Option.map(Option.scala:230)
  at org.apache.spark.sql.SparkSession.$anonfun$new$1(SparkSession.scala:180)
  at org.apache.spark.sql.internal.SQLConf$.get(SQLConf.scala:270)
  at org.apache.spark.sql.package$.withOrigin(package.scala:116)
  at org.apache.spark.sql.Column$.apply(Column.scala:46)
  at org.apache.spark.sql.Column$.apply(Column.scala:44)
  at com.databricks.sql.transaction.tahoe.stats.DataSkippingReader$.col(DataSkippingReader.scala:243)
  at com.databricks.sql.transaction.tahoe.stats.DataSkippingReader$.<init>(DataSkippingReader.scala:247)
  at com.databricks.sql.transaction.tahoe.stats.DataSkippingReader$.<clinit>(DataSkippingReader.scala)
  at com.databricks.sql.transaction.tahoe.DeltaConfigsBase.$init$(DeltaConfig.scala:557)
  at com.databricks.sql.transaction.tahoe.DeltaConfigs$.<init>(DeltaConfig.scala:829)
  at com.databricks.sql.transaction.tahoe.DeltaConfigs$.<clinit>(DeltaConfig.scala)
  at com.databricks.sql.SqlGatewayConfig$.sqlGatewayDefaultConfigs(SqlGatewayConfig.scala:135)
  at com.databricks.sql.SqlGatewayConfig$.setDefaultConfigurations(SqlGatewayConfig.scala:493)
  at com.databricks.sql.DatabricksEdge.customizeConf(DatabricksEdge.scala:504)
  at com.databricks.sql.DatabricksEdge.customizeConf$(DatabricksEdge.scala:501)
  at org.apache.spark.sql.internal.SessionStateBuilder.customizeConf(SessionState.scala:202)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.$anonfun$conf$2(BaseSessionStateBuilder.scala:109)
  at scala.Option.getOrElse(Option.scala:189)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.conf$lzycompute(BaseSessionStateBuilder.scala:103)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.conf(BaseSessionStateBuilder.scala:96)
  at org.apache.spark.sql.internal.BaseSessionStateBuilder.build(BaseSessionStateBuilder.scala:476)
  at org.apache.spark.sql.SparkSession$.org$apache$spark$sql$SparkSession$$instantiateSessionState(SparkSession.scala:1806)
  at org.apache.spark.sql.SparkSession.$anonfun$sessionState$2(SparkSession.scala:332)
  at scala.Option.getOrElse(Option.scala:189)
  at org.apache.spark.sql.SparkSession.sessionState$lzycompute(SparkSession.scala:330)
  at org.apache.spark.sql.SparkSession.sessionState(SparkSession.scala:325)
  at org.apache.spark.sql.SparkSession.conf$lzycompute(SparkSession.scala:396)
  at org.apache.spark.sql.SparkSession.conf(SparkSession.scala:394)
  at org.apache.spark.sql.SQLContext.setConf(SQLContext.scala:144)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.startThriftServer(SharedThriftServer.scala:159)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.$anonfun$beforeAll$1(SharedThriftServer.scala:91)
  at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
  at scala.util.Try$.apply(Try.scala:213)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.beforeAll(SharedThriftServer.scala:91)
  at org.apache.spark.sql.hive.thriftserver.SharedThriftServerBase.beforeAll$(SharedThriftServer.scala:88)
  at com.databricks.sql.hive.thriftserver.MultiClusterQueryResultCacheBaseSuite.org$apache$spark$sql$execution$qrc$MockCloudStorageTestUtils$$super$beforeAll(MultiClusterQueryResultCacheSuites.scala:51)
  at org.apache.spark.sql.execution.qrc.MockCloudStorageTestUtils.beforeAll(MockCloudStorageTestUtils.scala:23)
  at org.apache.spark.sql.execution.qrc.MockCloudStorageTestUtils.beforeAll$(MockCloudStorageTestUtils.scala:21)
  at com.databricks.sql.hive.thriftserver.MultiClusterQueryResultCacheBaseSuite.beforeAll(MultiClusterQueryResultCacheSuites.scala:86)
  at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:212)
  at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
  at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
  at org.apache.spark.SparkFunSuite.run(SparkFunSuite.scala:611)
  at org.scalatest.tools.SuiteRunner.run(SuiteRunner.scala:47)
  at org.scalatest.tools.Runner$.$anonfun$doRunRunRunDaDoRunRun$13(Runner.scala:1321)
  at org.scalatest.tools.Runner$.$anonfun$doRunRunRunDaDoRunRun$13$adapted(Runner.scala:1315)
  at scala.collection.immutable.List.foreach(List.scala:431)
  at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:1315)
  at org.scalatest.tools.Runner$.$anonfun$runOptionallyWithPassFailReporter$24(Runner.scala:992)
  at org.scalatest.tools.Runner$.$anonfun$runOptionallyWithPassFailReporter$24$adapted(Runner.scala:970)
  at org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:1481)
  at org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:970)
  at org.scalatest.tools.Runner$.run(Runner.scala:798)
  at com.databricks.scalatest.ScalaTestRunnerWrapper$.main(ScalaTestRunnerWrapper.scala:53)
  at com.databricks.scalatest.ScalaTestRunnerWrapper.main(ScalaTestRunnerWrapper.scala)

How was this patch tested?

Existing Ci should test it out.

Does this PR introduce any user-facing changes?

No.

@HyukjinKwon HyukjinKwon marked this pull request as draft September 23, 2024 03:41
@HyukjinKwon HyukjinKwon marked this pull request as ready for review September 23, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HyukjinKwon