[Spark] Replace the default pattern matching for LogicalRelation to LogicalRelationWithTable #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogicalRelationWithTable Signed-off-by: Jungtaek Lim <[email protected]>
|
I'm planning to propose the change of LogicalRelation (new parameter of constructor) in Spark 4.0, which will break all pattern matches. For creating an instance of LogicalRelation, I'll try to figure out the way to be compatible with existing constructor (and be back here to address the issue with shim if I fail). But for pattern matching, every addition of parameter require patterns to be updated. It won't be needed after this PR. |
Signed-off-by: Jungtaek Lim <[email protected]>
vkorukanti
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR proposes to replace the default pattern matching for
LogicalRelationto newly introduced pattern objectLogicalRelationWithTablewhich will be available in upcoming Spark 4.0.This change helps the project to modify less pieces of code when Spark makes the change to the LogicalRelation; most pattern matchings with LogicalRelation only extract the relation and catalog table, hence they fit with LogicalRelationWithTable.
How was this patch tested?
Existing tests would suffice.
Does this PR introduce any user-facing changes?
No.