[Spark][Version Checksum] Incrementally compute the checksum #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
approved these changes
Oct 29, 2024
| metadata = metadata, | ||
| protocol = protocol, | ||
| setTransactions = None, | ||
| domainMetadata = None, |
There was a problem hiding this comment.
Are these four fields intentionally skipped?
setTransactions = None,
domainMetadata = None,
histogramOpt = None,
allFiles = None
There was a problem hiding this comment.
Hey @felipepessoto , I will be adding those in a follow up PR since they can be a bit more complex. This PR handles the relatively simpler fields.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
#3799 added the capability to write a Checksum file after every commit. However, writing a checksum currently requires a full state reconstruction --- which is expensive. This PR adds the capability to compute most of the fields incrementally (apply the current delta on top of the last checksum to get the checksum of the current version). This works as long as the the actual operation performed matches exactly with the specified operation type in the commit. Note that this feature is gated behind a flag that is
trueby default.How was this patch tested?
Added tests in ChecksumSuite.
Does this PR introduce any user-facing changes?
No