[INFRA] Add structured logging linter script to github workflow #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedtang
changed the title
scottsand-db
reviewed
Nov 4, 2024
.github/workflows/spark_test.yaml
Outdated
| @@ -80,6 +80,11 @@ jobs: | |||
| pipenv run pip install pyarrow==8.0.0 | |||
| pipenv run pip install numpy==1.20.3 | |||
| if: steps.git-diff.outputs.diff | |||
| - name: Scala structured logging check | |||
There was a problem hiding this comment.
"check" is ambiguous. "style check"?
scottsand-db
reviewed
Nov 4, 2024
dev/structured_logging_style.py
Outdated
There was a problem hiding this comment.
Rename to spark_structured_logging_style.py
zedtang
force-pushed
the
add-structured-logging-style-check
branch
from
ecd1b89
to
db6cd7e
Compare
gengliangwang
approved these changes
Nov 5, 2024
scottsand-db
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add a python linter script to enforce new code to adhere to structured logging. There is a similar effort in Spark: apache/spark#47239.
How was this patch tested?
github workflow passed.
Does this PR introduce any user-facing changes?
No