Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve profile deletion dialog #3273

Merged
merged 3 commits into from
Sep 17, 2024
Merged

improve profile deletion dialog #3273

merged 3 commits into from
Sep 17, 2024

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Aug 30, 2024 •
edited
Loading

image

@adbenitez adbenitez added the enhancement actually in development, user visible enhancement label Aug 30, 2024
@adbenitez adbenitez requested a review from Hocuri August 30, 2024 22:13
@adbenitez adbenitez self-assigned this Aug 30, 2024
@adbenitez adbenitez changed the title improve account deletion dialog improve profile deletion dialog Aug 30, 2024
@github-actions GitHub Actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez
Copy link
Member Author

mmh I think the padding in the account item doesn't look good, also the account size is missing (desktop display that info) so maybe better create the item from scratch instead of trying to reuse the ContactSelectionListItem layout

@adbenitez
Copy link
Member Author

updated image capture

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez requested a review from r10s September 5, 2024 16:04
Hocuri
Hocuri approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I do think we should wait with merging until the last hotfix release is about a week ago. Then we will have plenty of time left before the next release, and we don't have to do a stable-branch-dance if we need another hotfix release.

@Hocuri Hocuri added the PR waiting for merge window potentially dangerous or otherwise unfitting PR waiting for better merge timing label Sep 11, 2024
@adbenitez adbenitez merged commit 529842a into main Sep 17, 2024
2 checks passed
@adbenitez adbenitez deleted the adb/improve-delete-dialog branch September 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hocuri Hocuri Hocuri approved these changes

@r10s r10s Awaiting requested review from r10s

Assignees

@adbenitez adbenitez

Labels
enhancement actually in development, user visible enhancement PR waiting for merge window potentially dangerous or otherwise unfitting PR waiting for better merge timing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adbenitez @Hocuri