Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new proxy_url list API #3292

Merged
merged 8 commits into from
Sep 26, 2024
Merged

use new proxy_url list API #3292

merged 8 commits into from
Sep 26, 2024

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Sep 16, 2024

image

close #3284

to to:

  • allow to add multiple proxies
  • if a proxy is clicked/selected/added, enable "use proxy" toggle
  • create proper layout for the ProxyUrl items
  • improve layout of ProxySettingsActivity
  • display connectivity status in the selected proxy
  • allow to delete and share proxies

@adbenitez adbenitez self-assigned this Sep 16, 2024
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez requested a review from r10s September 23, 2024 02:15
@adbenitez adbenitez marked this pull request as ready for review September 23, 2024 02:15
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@link2xt
Copy link
Contributor

link2xt commented Sep 23, 2024

Would be nice to have a way to show proxy as a QR code for easy sharing as well.

Sort of nice that proxy is not moving until you leave the screen.

When I have a proxy that is "Connected" and turn off "Use Proxy", it is strange that proxy shows "Not connected" status while actually I am connected, just without the proxy. Maybe better not show anything at all besides the proxy.
Maybe actually instead of having "Use Proxy" switch it would be better to have an option that says "Direct", together with connectivity status when no proxy is used, just as an item in the proxy list?

Copy link
Contributor

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good enough for merging, can also be refined later.

I have not looked at the code.

@adbenitez
Copy link
Member Author

adbenitez commented Sep 24, 2024

Would be nice to have a way to show proxy as a QR code for easy sharing as well.

that is planned for a subsequent PR as part of #3316

When I have a proxy that is "Connected" and turn off "Use Proxy", it is strange that proxy shows "Not connected" status while actually I am connected

you are "not connected" to the proxy ;) the idea is not to show the connectivity status in general but the connectivity to the proxy and it is only "connected", "connecting" or "not connected", I think it is clear to the user what this mean, it might look confusing to you because you know that internally this is just using the connectivity status of the account ;)

at the beginning I was removing the string and checkmark, but now that the selected proxy is not always at the top, it is not obvious what is the selected one, and showing just the checkmark with the protocol badge will look a bit weird

@link2xt link2xt merged commit bc6d676 into main Sep 26, 2024
2 checks passed
@link2xt link2xt deleted the adb/issue-3284 branch September 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New UI for proxy list
2 participants