-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new proxy_url list API #3292
Conversation
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
Would be nice to have a way to show proxy as a QR code for easy sharing as well. Sort of nice that proxy is not moving until you leave the screen. When I have a proxy that is "Connected" and turn off "Use Proxy", it is strange that proxy shows "Not connected" status while actually I am connected, just without the proxy. Maybe better not show anything at all besides the proxy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good enough for merging, can also be refined later.
I have not looked at the code.
that is planned for a subsequent PR as part of #3316
you are "not connected" to the proxy ;) the idea is not to show the connectivity status in general but the connectivity to the proxy and it is only "connected", "connecting" or "not connected", I think it is clear to the user what this mean, it might look confusing to you because you know that internally this is just using the connectivity status of the account ;) at the beginning I was removing the string and checkmark, but now that the selected proxy is not always at the top, it is not obvious what is the selected one, and showing just the checkmark with the protocol badge will look a bit weird |
close #3284
to to: