simplify 'Proxy Settings' to just 'Proxy' #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shorter, less cluttering - we usually do not say 'Settings' inside 'Settings', also having several 'Settings' menu entries in the main menu us not so nice - same as telegram is doing
r10s
force-pushed
the
r10s/just-proxy
branch
from
9229df5
to
689a8a1
Compare
|
To test the changes in this pull request, install this apk: |
where?
I agree with the menu, but in the proxy screen just "Proxy" doesn't look good IMHO, not 100% against this change tho |
|
also notice that the idea is to use an icon for the menu so the string will not be visible, only when long-pressing where it is more clear if it says "proxy settings" |
|
hm, on telegram iOS it is only "proxy", everywhere. i still find the long version superfluous, maybe in the dialog headline , but esp there it is clear that it is about "settings" :) +1 for an icon, but also then "Proxy" is fine |
adbenitez
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once merged, this needs a
./scripts/tx-push-source.sh