Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML-only mail shown as empty, should show something #1804

Closed
hpk42 opened this issue Aug 6, 2020 · 2 comments · Fixed by #1851
Closed

HTML-only mail shown as empty, should show something #1804

hpk42 opened this issue Aug 6, 2020 · 2 comments · Fixed by #1851
Assignees
@Hocuri
Labels
bug Something is not working

Comments

@hpk42
Copy link
Contributor

hpk42 commented Aug 6, 2020

Using: Desktop/Master from a few days ago.
Issue: got a reservation request html-only reply mail which shows as completely empty in DC
mime mail in source (hidden domains): hoc1.txt

How it shows in DC, including Message-info:

hoc2
@hpk42 hpk42 added the bug label Aug 6, 2020
@link2xt link2xt added bug Something is not working and removed bug2 labels Aug 7, 2020
@csb0730
Copy link

csb0730 commented Aug 10, 2020

I was faced a similar problem with peer using GMX mail client.
This produces bad html code and dehtml failed so that result is similar to the message details shown at top: no body text.
But the fix in dehtml.rs related to end of names is fixed meanwhile as I found: reader.check_end_names(false).

It looks like another issue in mail produces a crash in dehtml too.

Old c-core showed the raw mail sources in such a case. IMHO this would be a better approach than showing nothing?

@Hocuri Hocuri mentioned this issue Aug 19, 2020
Closed
@Hocuri
Copy link
Collaborator

Hocuri commented Aug 19, 2020

I can reproduce this in a test. The problem is that the html starts with <!doctype html>, when I remove this line, it works again.

@Hocuri Hocuri self-assigned this Aug 19, 2020
Hocuri added a commit that referenced this issue Aug 19, 2020
@Hocuri
Fix #1804: remove <!doctype html> and accept invalid HTML
4ba8d5a 
This fixes #1804 in two ways: First, it removes a <!doctype html> from
the start of the mail, if there is any.

Then, it parses the html itself it quick-xml fails, just stripping
everything between < and >.

Both of these would have fixed this specific issue.

Also, add tests for both fixes.
@Hocuri Hocuri mentioned this issue Aug 19, 2020
Merged
hpk42 pushed a commit that referenced this issue Aug 19, 2020
@Hocuri @hpk42
Fix #1804: remove <!doctype html> and accept invalid HTML
1a736ca 
This fixes #1804 in two ways: First, it removes a <!doctype html> from
the start of the mail, if there is any.

Then, it parses the html itself it quick-xml fails, just stripping
everything between < and >.

Both of these would have fixed this specific issue.

Also, add tests for both fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hocuri Hocuri

Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1804: remove <!doctype html> and accept invalid HTML deltachat/deltachat-core-rust
4 participants
@hpk42 @Hocuri @link2xt @csb0730