api: remove unused dc_accounts_all_work_done()
#5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/remove-all-work-done
branch
from
3572cdc
to
0d57dff
Compare
iequidoo
approved these changes
Mar 27, 2024
r10s
changed the title
dc_accounts_all_work_done()dc_accounts_all_work_done()
it was used by iOS to know when a background fetch was complete; meanwhile the superiour dc_accounts_background_fetch() is used for that. there is still the corresponding context function dc_all_work_done(), this not used by any UI as well, however, it is in use by a python tests.
r10s
force-pushed
the
r10s/remove-all-work-done
branch
from
0d57dff
to
ecff0c9
Compare
r10s
changed the title
dc_accounts_all_work_done()dc_accounts_all_work_done()
|
i think, it is an API change, anyways, thanks for reminding to the convention! |
|
CI fails because |
link2xt
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was used by iOS to know when a background fetch was complete; meanwhile the superiour
dc_accounts_background_fetch()is used for that.there is still the corresponding context function
dc_all_work_done(), this not used by any UI as well, however, it is in use by a python tests.not sure, what to do with it, at a first glance, the test still seems useful.